Skip to content
This repository has been archived by the owner on May 5, 2020. It is now read-only.

Fix for Flarum Beta 10 + russian language #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dexif
Copy link

@dexif dexif commented Oct 8, 2019

Hey! I've fixed the extension for Beta 10.
Also i've added "Link Telegram" button to the user settings page, russian language and new notification types:

'newDiscussionInTag',
'newPostInTag',
'discussionCreated', // for fof/subscribed extension
'userCreated', // for fof/subscribed extension

@Ralkage
Copy link

Ralkage commented Oct 10, 2019

Hi @dexif and thank you for your PR again! It will be reviewed this week and if everything is good to go, we'll go ahead and merge it :)

@dexif
Copy link
Author

dexif commented Oct 22, 2019

@Ralkage I can add new commit with changes to transit from flagrow to fof . If you want of course. Maybe it simplify your work?

@laTruffe79
Copy link

Hi @dexif and thank you for your PR again! It will be reviewed this week and if everything is good to go, we'll go ahead and merge it :)

Please, when will you commit this PR in FOF ?

@clarkwinkelmann
Copy link
Contributor

@Ralkage I assigned you, let me know if you need help.

Something I noticed: we decided to not include non-English translations in FoF extensions, so the move from Flagrow to FoF means we sadly won't include your Russian translations.

@laTruffe79
Copy link

Hi @dexif and thank you for your PR again! It will be reviewed this week and if everything is good to go, we'll go ahead and merge it :)

Hello @Ralkage do you have an idea when you will have the time to merge this PR we are many to wait your review. Thank you

@Ralkage
Copy link

Ralkage commented Nov 5, 2019

@dexif hi again, I decided that I'll update this for Beta 10 from scratch along with progressively adding and testing the additional changes/feautes you added in this PR :)

@laTruffe79
Copy link

Any news about this PR since October 8th ?...😞

@dexif
Copy link
Author

dexif commented Feb 18, 2020

It looks like the extension is abandoned. Very disappointing...

@clarkwinkelmann
Copy link
Contributor

@Ralkage can you please update us on the status ? If you're not available somebody else from FoF can take on the review of this PR.

Personally I had a few changes I would request if we go with this PR, but I didn't want to write all that if you were thinking of updating from scratch.

@clarkwinkelmann
Copy link
Contributor

@Ralkage status report please ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants