Fix php84 deprecations

api/midgard/collector.php

@@ -19,7 +19,7 @@ class midgard_collector extends midgard_query_builder
 
     private array $value_properties = [];
 
-    public function __construct(string $class, string $field = null, $value = null)
+    public function __construct(string $class, ?string $field = null, $value = null)
     {
         parent::__construct($class);
         if ($field) {

src/api/error/exception.php

@@ -70,7 +70,7 @@ class exception extends base_exception
         self::OBJECT_IS_LOCKED => "Object is locked",
     ];
 
-    public function __construct($message = "Undefined error", $code = self::ERROR, base_exception $previous = null)
+    public function __construct($message = "Undefined error", $code = self::ERROR, ?base_exception $previous = null)
     {
         midgard_connection::get_instance()->set_error($code);
         midgard_connection::get_instance()->set_error_string($message);
@@ -164,7 +164,7 @@ public static function object_no_parent() : self
         return new self(self::$messages[self::OBJECT_NO_PARENT], self::OBJECT_NO_PARENT);
     }
 
-    public static function invalid_property_value(string $message = null) : self
+    public static function invalid_property_value(?string $message = null) : self
     {
         $message ??= self::$messages[self::INVALID_PROPERTY_VALUE];
         return new self($message, self::INVALID_PROPERTY_VALUE);

src/api/mgdobject.php

@@ -529,7 +529,7 @@ public function has_parameters() : bool
         return !$this->get_collection('midgard_parameter')->is_empty($this->guid);
     }
 
-    public function list_parameters(string $domain = null) : array
+    public function list_parameters(?string $domain = null) : array
     {
         $constraints = [];
         if ($domain) {

src/mgdschema/type.php

@@ -59,7 +59,7 @@ public function __construct(SimpleXMLElement $attributes)
         }
     }
 
-    public function add_property(node $property, string $name = null)
+    public function add_property(node $property, ?string $name = null)
     {
         $name ??= $property->name;
 

src/storage/connection.php

@@ -80,7 +80,7 @@ public static function get_user() : ?user
         return self::$instance->user;
     }
 
-    public static function set_user(user $user = null)
+    public static function set_user(?user $user = null)
     {
         if (self::$instance === null) {
             throw new \Exception('Not initialized');