Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rwkv7.py: Remove in-place operations #144

Closed
wants to merge 1 commit into from
Closed

Update rwkv7.py: Remove in-place operations #144

wants to merge 1 commit into from

Conversation

Triang-jyed-driung
Copy link
Contributor

No description provided.

@sustcsonglin
Copy link
Collaborator

Hi @Triang-jyed-driung, thank you for the PR! I have a quick question: What is the reasoning behind removing in-place operations in this context?

@yzhangcs
Copy link
Member

@Triang-jyed-driung Hello,
v_first = v
I think this change would make v_first useless as it is defined out of forward?

@Triang-jyed-driung
Copy link
Contributor Author

Hi @Triang-jyed-driung, thank you for the PR! I have a quick question: What is the reasoning behind removing in-place operations in this context?

For gradient computation.
I may have broken something; I will PR again later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Triang-jyed-driung @sustcsonglin @yzhangcs