Check for CWE-337 #439
Merged
Check for CWE-337 #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enkelmann
suggested changes
Feb 15, 2024
There was a problem hiding this comment.
We need to add acceptance tests for this check! Also, reusing code from the CWE-476 check means that the analysis is dependent on the Pointer Inference analysis, so we have to tell the caller code that the Pointer Inference analysis has to be computed before this check.
added 2 commits
February 20, 2024 14:37
* Add "artifical_sample" * Rename `sinks` to `seeding_functions` * Use `expect()` instead of `unwrap()` for the `Config` * Bail early if either there are no sinks or no sources * Only use one `computation` instead of one per call to a source.
Enkelmann
suggested changes
Feb 21, 2024
added 2 commits
February 21, 2024 10:49
Enkelmann
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a check for CWE-337: Predictable Seed in Pseudo-Random Number Generator (PRNG)
The check works by reusing the taint-tracking code from the check for CWE-467 to track return values of "source" functions (e.g.:
time) to arguments of "sink" functions (e.g:srand).