Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intercom backend refactoring: make data flow comprehensible #1251

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

jstucke
Copy link
Collaborator

@jstucke jstucke commented Aug 27, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 90.80460% with 8 lines in your changes missing coverage. Please review.

Project coverage is 91.88%. Comparing base (4b87ffa) to head (6e948f0).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/intercom/common_redis_binding.py 75.75% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1251      +/-   ##
==========================================
- Coverage   92.16%   91.88%   -0.28%     
==========================================
  Files         377      376       -1     
  Lines       22934    20949    -1985     
==========================================
- Hits        21138    19250    -1888     
+ Misses       1796     1699      -97     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dorpvom dorpvom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider questions and give me some feedback

src/intercom/back_end_binding.py Outdated Show resolved Hide resolved
src/intercom/common_redis_binding.py Show resolved Hide resolved
@dorpvom dorpvom merged commit bd5bdb0 into master Dec 2, 2024
10 checks passed
@dorpvom dorpvom deleted the intercom-refactoring branch December 2, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants