Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update postgres to v17 #1245

Merged
merged 6 commits into from
Nov 18, 2024
Merged

Update postgres to v17 #1245

merged 6 commits into from
Nov 18, 2024

Conversation

jstucke
Copy link
Collaborator

@jstucke jstucke commented Aug 8, 2024

  • update postgres from 14 to 17
  • also fixed bugs:
    • fixed a bug in the init postgres script when the local postgres instance does not run on the default port
    • fixed a copy&paste bug in a test fixture

@jstucke jstucke requested a review from maringuu August 8, 2024 13:32
@jstucke jstucke self-assigned this Aug 8, 2024
src/install/db.py Outdated Show resolved Hide resolved
src/install/db.py Outdated Show resolved Hide resolved
src/install/db.py Outdated Show resolved Hide resolved
src/install/db.py Outdated Show resolved Hide resolved
changed postgres version to 17 and removed the duplicate call to psql
@jstucke jstucke changed the title Update postgres Update postgres to v17 Nov 12, 2024
@jstucke jstucke requested a review from dorpvom November 12, 2024 14:39
Copy link
Collaborator

@dorpvom dorpvom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the process of checking if the update works correctly

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.90%. Comparing base (50a0bf4) to head (a75e94a).
Report is 700 commits behind head on master.

Files with missing lines Patch % Lines
src/helperFunctions/install.py 0.00% 1 Missing ⚠️
src/init_postgres.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1245      +/-   ##
==========================================
- Coverage   95.33%   91.90%   -3.43%     
==========================================
  Files         347      376      +29     
  Lines       20034    21038    +1004     
==========================================
+ Hits        19099    19336     +237     
- Misses        935     1702     +767     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dorpvom dorpvom merged commit 86a6b3f into master Nov 18, 2024
9 checks passed
@dorpvom dorpvom deleted the update-postgres branch November 18, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants