Add enabled config to models without it #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide your name and company
Santina Brohen, Pleo
Link the issue/feature request which this PR is meant to address
Link to issue here.
Some context here as well:
Currently, the package expects certain sources to be available. Some models, but not all, include the enabled config, which makes it possible to skip the model if the source is not available. For example,
stg_zuora__credit_balance_adjustment
includes the following:{{ config(enabled=var('zuora__using_credit_balance_adjustment', true)) }}
(code here). Of the 19 models, only 4 can be disabled:stg_zuora__credit_balance_adjustment
stg_zuora__refund
stg_zuora__refund_invoice_payment
stg_zuora__taxation_item
At Pleo, we are not ingesting all the sources that are expected by the package, so even when leveraging the enabled config in the models where it's available, we are still left with models raising errors.
Detail what changes this PR introduces and how this addresses the issue/feature request linked above.
With this PR, it is possible to disable any model, not just the subset listed above. Having the ability to disable models for which the sources are not ingested via Fivetran is a great feature, and it opens up use of this package even when only a few Fivetran sources are available.
How did you validate the changes introduced within this PR?
As recommended by you here, I followed this dbt Discourse article to contribute.
Before making the changes, we had four models that raised errors because the sources are not available. I ran
dbt build --select +zuora_source
and the following shows the error:After making the changes and disabling the models for sources we do not ingest, I ran
dbt build --select +zuora_source
again; no errors were raised.I then removed one of the new variables to ensure that it still correctly raised an error; it did:
Note:
zuora__using_contact: false
is commented out.Which warehouse did you use to develop these changes?
BigQuery
Did you update the CHANGELOG?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Provide an emoji that best describes your current mood
🦄
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.
PR Template
Community Pull Request Template (default)
Maintainer Pull Request Template (to be used by maintainers)