Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FCE-937] Fix expo doctor issues #255

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

maksg
Copy link
Collaborator

@maksg maksg commented Nov 27, 2024

Description

Fixed warnings which appeared when running expo doctor

Motivation and Context

Expo doesn't recommend using different package versions than those used by Expo, it may cause issues along the way.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link

linear bot commented Nov 27, 2024

@mironiasty
Copy link
Member

WDYT about somewhere info about how to use expo doctor? Maybe in CONTRIBUTING.md?

"@react-navigation/bottom-tabs": "^6.6.1",
"@react-navigation/native": "^6.1.18",
"@react-navigation/native-stack": "^6.11.0",
"expo": "^52.0.8",
"expo": "~52.0.11",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: 👍

@maksg
Copy link
Collaborator Author

maksg commented Nov 29, 2024

@mironiasty I've added the info about expo doctor to CONTRIBUTING.md

Also I think we should consider changing dependabot.yml to only update Expo and it's dependencies because otherwise the expo doctor will throw warnings again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants