[FCE-929] Add useUpdatePeerMetadata hook #254
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maksg
approved these changes
Nov 27, 2024
MiloszFilimowski
approved these changes
Nov 27, 2024
| * @param peerMetadata string indexed record with metadata, that will be available to all other peers | ||
| * @category Connection | ||
| */ | ||
| updatePeerMetadata, |
There was a problem hiding this comment.
nitpick: This is already a static reference so useCallback does not add anything here, it could be written as such:
updatePeerMetadata: RNFishjamClientModule.updatePeerMetadata<PeerMetadata>
but I'm ok with useCallback solution as well.
There was a problem hiding this comment.
I was thinking about it - and decided to go for useCallback to made it more explicit. But I don't have strong opinion on which solution is better 🤷
There was a problem hiding this comment.
Then let's leave it as it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of static method, let's have hook that will allow updating metadata.
I also updated jsdoc comments - to remove deprecated methods from existing categories (so they are not easily discoverable in documentation)
Motivation and Context
Let's have unified API that rely mostly on hooks
Types of changes
not work as expected)
Checklist:
Screenshots (if appropriate)