Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo - [Failed Pipeline] - Added dockerfile bug #97

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Demo - [Failed Pipeline] - Added dockerfile bug #97

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f22e14
add Dockerfile
wvl94 Nov 5, 2024
45b9f1c
update dockerfile
wvl94 Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
FROM node:18-alpine AS build
WORKDIR /app
COPY package*.json ./
RUN npm install
COPY . .

FROM node:18-alpine
WORKDIR /app
COPY --from=build /node_modules ./node_modules
EXPOSE 8080
CMD ["npm", "start", "--no-update-notifier"]
Comment on lines +7 to +11
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alt text

The Dockerfile does not specify a non-root user, which can pose security risks. You should add a non-root user to enhance security by including the following lines:

RUN addgroup -S appgroup && adduser -S appuser -G appgroup
USER appuser

This ensures the application runs with limited privileges.

Loading