Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pod pdb #91

Closed
wants to merge 1 commit into from
Closed

Add pod pdb #91

wants to merge 1 commit into from

Conversation

WilmsJochen
Copy link
Contributor

@WilmsJochen WilmsJochen commented Oct 30, 2024


💡 Summary generated by FirstMate:

  • Created new file /charts/templates/pdb.yaml for PodDisruptionBudget configuration
  • Defines apiVersion, kind, metadata, and spec for managing pod disruptions
  • Set minAvailable to 3 and maxUnavailable to 2 for pod availability management

Copy link

firstmatebot bot commented Oct 30, 2024

PR Review

🔥 Your pull request seems to follow the company guidelines. LGTM! 🎉

Generated by Firstmate to make sure you can focus on coding new features.

Copy link

firstmatebot bot commented Oct 30, 2024

Some of the pipelines in this PR crashed. I did a quick analysis:

Failure Analysis

The pipeline crashed during the helm lint step due to a YAML parsing error in the newly created pdb.yaml file. The error message indicates that there is an issue at line 7 of the file:

[ERROR] templates/pdb.yaml: unable to parse YAML: error converting YAML to JSON: yaml: line 7: mapping values are not allowed in this context

This suggests that there is likely an indentation problem or a syntax error in the YAML structure. Specifically, the maxUnavailable line appears to have incorrect indentation.

Suggested Fix

To resolve the issue, correct the indentation in the pdb.yaml file. The corrected version should look like this:

apiVersion: policy/v1
kind: PodDisruptionBudget
metadata:
  name: {{ .Chart.Name }}-pdb
spec:
  minAvailable: 3
  maxUnavailable: 2
  selector:
    matchLabels:
      app: {{ .Chart.Name }}

Ensure that maxUnavailable and selector are properly aligned with minAvailable under the spec section. After making this change, the pipeline should pass the helm lint step.

@wvl94 wvl94 closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants