Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

empty change #37

Closed
wants to merge 1 commit into from
Closed

empty change #37

wants to merge 1 commit into from

Conversation

wvl94
Copy link
Contributor

@wvl94 wvl94 commented Sep 3, 2024

No description provided.

Copy link

firstmatebot bot commented Sep 3, 2024

PR review

👍 Your pull request looks according to the guidelines!


sidenote:

❌ Deployment & testing pipelines:
   The repo follows the example structure closely but is missing Postman tests in the PR validation pipeline.
❌ Docker file structure:
   Your Dockerfile does not follow the example closely. It runs as root and lacks a non-root user setup. Additionally, it does not use multi-stage builds and the Node.js version is different.
✅ File structure based on example repo
✅ Usage of proper tests [Unit tests, Postman etc.]

❌ General coding guidelines:
   - Updated Readme File:
      The README.md file is incomplete. It should contain setup instructions and how to run the application.
   - Postman Tests in PR:
      No evidence of Postman tests being executed in the pipeline. Add Postman tests and ensure they are triggered in the pipeline.
   - Multi-Stage Dockerfile:
      The Dockerfile does not use multi-stage builds. Implement multi-stage builds to optimize the image size.
   - Dockerfile Non-Root User:
      The Dockerfile runs as root. Modify it to use a non-root user for better security.
   - Env Variables in Default Env:
      Environment variables are not listed in a default_env file. Add a default_env file for developer purposes.
   - Unit Tests for Services:
      No unit tests found for functions in the services folder. Implement unit tests for these functions.

⚠️ This repo is currently not following company guidelines.

You might want to look into this so I prepared some PR's to bring it up to date.

Generated by Firstmate to make sure you can focus on coding new features.

@wvl94 wvl94 closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant