Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/firstmate-docker-align-06398f1c #31

Closed

Conversation

firstmate-test-bot[bot]
Copy link

Dockerfile Optimization

I have optimized the Dockerfile to align with company best practices and improve security and efficiency. Here are the changes made:

➡️ Updated Node.js version: Upgraded from node:19-alpine to node:20-alpine for better performance and security updates.

➡️ Multi-stage build: Implemented a multi-stage build to reduce the final image size and improve build efficiency.

➡️ Non-root user: Added a non-root user to enhance security. Running containers as root is a security risk.

➡️ Layer optimization: Reordered instructions to optimize Docker layer caching, which speeds up the build process.

These changes ensure that the Dockerfile adheres to the company's guidelines, enhancing security and efficiency.

Copy link
Author

PR review

👍 Your pull request looks according to the guidelines!

sidenote:

✅ Deployment & testing pipelines
❌ Docker file structure:
   Your Dockerfile is missing from the repository. Ensure it is placed at the root level of the project. Additionally, follow the provided example closely, including using multiple build stages, not running as root, and maintaining the order of commands.
✅ File structure based on example repo
✅ Usage of proper tests [Unit tests, Postman etc.]
❌ General coding guidelines:
   - Updated Readme File:
      The README.md file is incomplete. It should contain setup instructions and how to run the application.
   - Use Retries for External APIs:
      No evidence of retries in API calls. Implement retry logic for external API calls.
⚠️ This repo is currently not following company guidelines.

You might want to look into this so I prepared some PR's to bring it up to date.

Generated by Firstmate to make sure you can focus on coding new features.

@wvl94 wvl94 closed this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant