Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo: add log of user data and public API route. #108

Closed
wants to merge 1 commit into from

Conversation

WilmsJochen
Copy link
Contributor

@WilmsJochen WilmsJochen commented Nov 13, 2024

💡 PR Summary generated by FirstMate

New API Route and Logging Enhancements

Changes:
New API Route:

  • Added /user-data/:id endpoint in exampleRouter.js to fetch user data.

Logging Implementation:

  • Integrated logging in ExampleService to log user data retrieval.
  • Created NewService class with logging for data fetching by ID.

CI Workflow Update:

  • Modified .github/workflows/firstmate.yaml to run tests after package installation.

TLDR: Introduced a new user data API route, added logging for data retrieval, and updated CI workflow to include tests. Focus on the new endpoint and logging in ExampleService.

Generated by FirstMate and automatically updated on every commit.

Copy link

firstmatebot bot commented Nov 13, 2024

FirstMate is reviewing your PR:

  • Using your custom guidelines & best practices
  • Found code changes in 4 files

Live status:

  alt text Studying your Guideline Repository
  alt text Evaluating code changes
  alt text Formulating feedback based on best practices

@wvl94 wvl94 closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants