Merge pull request #1412 from jasonlyc/bug_fix

fix seq reference error in conn check event handler of routing plugin
firewalla · Nov 13, 2024 · 83249af · 83249af
2 parents c3703f5 + 7b4f510
commit 83249af
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/plugins/routing/routing_plugin.js b/plugins/routing/routing_plugin.js
@@ -1107,9 +1107,9 @@ class RoutingPlugin extends Plugin {
               break;
             }
             case "primary_standby": {
-              const activeWanPlugins = this.getActiveWANPlugins();
+              const activeWanStatus = Object.values(this._wanStatus).filter(status => status.active).sort((a, b) => a.seq - b.seq);
               const failback = (this.networkConfig["default"] && this.networkConfig["default"].failback) || false;
-              if (_.isEmpty(activeWanPlugins) || (failback && currentStatus.seq < activeWanPlugins[0].seq))
+              if (_.isEmpty(activeWanStatus) || (failback && currentStatus.seq < activeWanStatus[0].seq))
                 // apply WAN settings in failback mode if a WAN with higher rank is back to ready
                 changeActiveWanNeeded = true;
               break;