Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building firectl requires at least Go 1.14 #61

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Building firectl requires at least Go 1.14 #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ else
endif

build-in-docker:
docker run --rm -v $(CURDIR):/firectl --workdir /firectl golang:1.12 make
docker run --rm -v $(CURDIR):/firectl --workdir /firectl golang:1.14 make

test:
go test -v ./...
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ Building

The default Makefile rule executes `go build` and relies on the Go toolchain
installed on your computer.
_We use [go modules](https://github.com/golang/go/wiki/Modules), so you need to
build with Go 1.11 or newer._
_We use [go modules](https://github.com/golang/go/wiki/Modules), and building
requires Go 1.14 or newer._

If you do not have a new-enough Go toolchain installed, you can use `make
build-in-docker`. This rule creates a temporary Docker container which builds
Expand Down