Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: More test fixes #71

Merged
merged 4 commits into from
Oct 17, 2024
Merged

test: More test fixes #71

merged 4 commits into from
Oct 17, 2024

Conversation

stepansergeevitch
Copy link
Collaborator

Added more minor test fixes:

  • Use regexp_extract instead of regexp_like (to return actual value instead of true/false)
  • Fix some internal tests
  • Report that JDBC doesn't send JVM timezone to backend

@stepansergeevitch stepansergeevitch requested a review from a team as a code owner October 16, 2024 10:38
@stepansergeevitch stepansergeevitch self-assigned this Oct 16, 2024
ptiurin
ptiurin approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@ptiurin ptiurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

test/metabase/test/data/firebolt.clj Outdated Show resolved Hide resolved
@stepansergeevitch stepansergeevitch merged commit 7aa0bea into develop Oct 17, 2024
1 of 2 checks passed
@stepansergeevitch stepansergeevitch deleted the more-test-fixes branch October 17, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptiurin ptiurin ptiurin approved these changes

Assignees

@stepansergeevitch stepansergeevitch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stepansergeevitch @ptiurin