fix: use default implementation for describe-database #69
Conversation
stepansergeevitch
commented
Oct 10, 2024
stepansergeevitch
commented
- Improve describe-database to use the default jdbc implementation, since we support it now on JDBC side. It's more accurate as well
- Report schemas as not supported (we cannot set table schema)
src/metabase/driver/firebolt.clj
Outdated
| (defmethod sql-jdbc.sync/excluded-schemas :firebolt | ||
| [_] | ||
| #{"information_schema"}) |
There was a problem hiding this comment.
Is this excluding I_S tables from metabase altogether? There might be cases where users want to access them too.
There was a problem hiding this comment.
This will just exclude them from the listing. They would still be able to access them via a custom query. As I see from other connectors, that's how it's usually done
https://github.com/metabase/metabase/blob/master/modules/drivers/snowflake/src/metabase/driver/snowflake.clj#L679
https://github.com/metabase/metabase/blob/master/src/metabase/driver/postgres.clj#L789
https://github.com/metabase/metabase/blob/master/src/metabase/driver/mysql.clj#L577
There was a problem hiding this comment.
I'd run this by the Product team - in our connectors for Tableau and Superset we have information schema exposed by default.
There was a problem hiding this comment.
I'll create a ticket for this. I'll enable infromation_schema for now
There was a problem hiding this comment.
