Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FIR-35270): Avoid printing secrets in logs #454

Merged
merged 2 commits into from
Sep 20, 2024
Merged

fix(FIR-35270): Avoid printing secrets in logs #454

merged 2 commits into from
Sep 20, 2024

Conversation

ptiurin
Copy link
Contributor

@ptiurin ptiurin commented Sep 19, 2024 •
edited
Loading

Sanitizing logs to avoid printing secrets. Bumping down query printing to debug level instead.
Also fixed skipped tests.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ptiurin
Copy link
Contributor Author

ptiurin commented Sep 19, 2024

Integration tests are passing, failures are consistent with master.

@ptiurin ptiurin marked this pull request as ready for review September 19, 2024 16:26
@ptiurin ptiurin requested a review from a team as a code owner September 19, 2024 16:26
@ptiurin ptiurin merged commit 487ec3d into master Sep 20, 2024
4 checks passed
@ptiurin ptiurin deleted the sanitize-logging branch September 20, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stepansergeevitch stepansergeevitch stepansergeevitch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ptiurin @stepansergeevitch