refactor: FIR-35469 remove account resolve endpoint from jdbc #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptiurin
reviewed
Sep 2, 2024
| for (Entry<String, String> e : systemEngineUrlUrlParams.entrySet()) { | ||
| loginProperties.addProperty(e); | ||
| } | ||
| return loginProperties | ||
| .toBuilder() | ||
| .systemEngine(true) | ||
| .compress(false) | ||
| .accountId(accountId) | ||
| .accountId(null) |
There was a problem hiding this comment.
Can we not remove accountid line here altogether since this is a builder? Or are we wiping it on purpose?
There was a problem hiding this comment.
Just left it like this for visibility. Also, I'm not sure what default value is set, so setting this explicitly made sense to me
There was a problem hiding this comment.
The default here is null so let's remove this line to avoid unnecessary complexity.
stepansergeevitch
changed the title
ptiurin
approved these changes
Sep 3, 2024
| for (Entry<String, String> e : systemEngineUrlUrlParams.entrySet()) { | ||
| loginProperties.addProperty(e); | ||
| } | ||
| return loginProperties | ||
| .toBuilder() | ||
| .systemEngine(true) | ||
| .compress(false) | ||
| .accountId(accountId) | ||
| .accountId(null) |
There was a problem hiding this comment.
The default here is null so let's remove this line to avoid unnecessary complexity.
|
stepansergeevitch
deleted the
FIR-35469-remove-account-resolve-endpoint-from-jdbc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed account resolve call. Still leaving infraVersion variable in place since it's currently used to distinguish between fb1.0 and 2.0. Refactoring it out would be a much bigger effort