Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publishing artifact to the central maven repository #283

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

alexradzin
Copy link
Collaborator

No description provided.

@alexradzin alexradzin force-pushed the maven-central-attempt branch from 341c846 to 4de747c Compare October 4, 2023 18:29
updated java version to 17 because it is required by plugin org.quiltmc.gradle.licenser. Source and target compatibility is still 11.
@alexradzin alexradzin force-pushed the maven-central-attempt branch from f27ddc9 to ca53554 Compare October 4, 2023 19:00
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@stepansergeevitch stepansergeevitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ptiurin ptiurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise lgtm. However, I'm thinking should we publish to both repsy and MC? Since we're trying to keep 2.* version of JDBC backwards compatible. Otherwise any existing users won't get any future updates to 2.* JDBC. We can remove repsy altogether for JDBC 3.* since that one is a major version.

Comment on lines +303 to +305
signing {
sign publishing.publications
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does signing work on github? Do we store the private key somewhere?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I have added a secret. I am planning write document on Sunday

@alexradzin
Copy link
Collaborator Author

Otherwise lgtm. However, I'm thinking should we publish to both repsy and MC? Since we're trying to keep 2.* version of JDBC backwards compatible. Otherwise any existing users won't get any future updates to 2.* JDBC. We can remove repsy altogether for JDBC 3.* since that one is a major version.

Generally it is possible, but I do not understand why. Maven central + sonatype a standard, "default" repositories. Artefacts published there are available for any build that references it as a dependency without mentioning the repository URL. I even do not know why Repsy has been chosen and do not sure that we have to continue support it. Moreover now the group ID is changed. However this support can be restored if we really need it.

@alexradzin alexradzin merged commit 98ecc9d into master Oct 5, 2023
5 checks passed
@alexradzin alexradzin deleted the maven-central-attempt branch October 5, 2023 15:00
@ptiurin
Copy link
Contributor

ptiurin commented Oct 5, 2023

Generally it is possible, but I do not understand why. Maven central + sonatype a standard, "default" repositories. Artefacts published there are available for any build that references it as a dependency without mentioning the repository URL.

Would users that had previously used repsy and still reference repsy in their maven config get updates to JDBC 2.*? I don't understand why are we making those changes without considering the impact.

I even do not know why Repsy has been chosen

https://packboard.atlassian.net/wiki/spaces/INTERFACES/pages/2887057554/JDBC+connector+deployment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants