-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
publishing artifact to the central maven repository #283
Conversation
341c846
to
4de747c
Compare
updated java version to 17 because it is required by plugin org.quiltmc.gradle.licenser. Source and target compatibility is still 11.
f27ddc9
to
ca53554
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise lgtm. However, I'm thinking should we publish to both repsy and MC? Since we're trying to keep 2.* version of JDBC backwards compatible. Otherwise any existing users won't get any future updates to 2.* JDBC. We can remove repsy altogether for JDBC 3.* since that one is a major version.
signing { | ||
sign publishing.publications | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does signing work on github? Do we store the private key somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I have added a secret. I am planning write document on Sunday
Generally it is possible, but I do not understand why. Maven central + sonatype a standard, "default" repositories. Artefacts published there are available for any build that references it as a dependency without mentioning the repository URL. I even do not know why Repsy has been chosen and do not sure that we have to continue support it. Moreover now the group ID is changed. However this support can be restored if we really need it. |
Would users that had previously used repsy and still reference repsy in their maven config get updates to JDBC 2.*? I don't understand why are we making those changes without considering the impact.
https://packboard.atlassian.net/wiki/spaces/INTERFACES/pages/2887057554/JDBC+connector+deployment |
No description provided.