Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIR-26736 improved support of infinity #280

Merged
merged 1 commit into from
Oct 5, 2023
Merged

FIR-26736 improved support of infinity #280

merged 1 commit into from
Oct 5, 2023

Conversation

alexradzin
Copy link
Collaborator

Also added conversion from int floating point types

ptiurin
ptiurin approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@ptiurin ptiurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from that lgtm

src/main/java/com/firebolt/jdbc/type/BaseType.java Outdated Show resolved Hide resolved
@alexradzin
FIR-26736 improved support of infinity
0ba9826 
Also added conversion from int floating point types
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@alexradzin alexradzin merged commit cdad7fa into master Oct 5, 2023
5 checks passed
@alexradzin alexradzin deleted the FIR-26736-infinity branch October 5, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptiurin ptiurin ptiurin approved these changes

@stepansergeevitch stepansergeevitch Awaiting requested review from stepansergeevitch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexradzin @ptiurin