test: relax version checks (#489)

firebolt-db · Dec 23, 2024 · 1a43081 · 1a43081
1 parent b75c7df
commit 1a43081
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/src/test/java/com/firebolt/FireboltDriverTest.java b/src/test/java/com/firebolt/FireboltDriverTest.java
@@ -21,6 +21,7 @@
 import java.util.stream.Collector;
 import java.util.stream.Collectors;
 
+import static org.junit.Assert.assertTrue;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
@@ -93,7 +94,9 @@ void jdbcCompliant() {
 	void version() {
 		FireboltDriver fireboltDriver = new FireboltDriver();
 		assertEquals(3, fireboltDriver.getMajorVersion());
-		assertEquals(5, fireboltDriver.getMinorVersion());
+		int minorVersion = fireboltDriver.getMinorVersion();
+		// Sanity check for minor version
+		assertTrue(minorVersion >= 0 && minorVersion < 100);
 	}
 
 	@ParameterizedTest

diff --git a/src/test/java/com/firebolt/jdbc/metadata/FireboltDatabaseMetadataTest.java b/src/test/java/com/firebolt/jdbc/metadata/FireboltDatabaseMetadataTest.java
@@ -356,12 +356,13 @@ void shouldGetDriverMajorVersion() {
 
 	@Test
 	void shouldGetDriverMinorVersion() {
-		assertEquals(5, fireboltDatabaseMetadata.getDriverMinorVersion());
+		int minorVersion = fireboltDatabaseMetadata.getDriverMinorVersion();
+		assertTrue(minorVersion >= 0 && minorVersion < 100);
 	}
 
 	@Test
 	void shouldGetDriverVersion() throws SQLException {
-		assertEquals("3.5.0", fireboltDatabaseMetadata.getDriverVersion());
+		assertTrue(fireboltDatabaseMetadata.getDriverVersion().matches("3\\.\\d+\\.\\d+"));
 	}
 
 	@Test

diff --git a/src/test/java/com/firebolt/jdbc/util/VersionUtilTest.java b/src/test/java/com/firebolt/jdbc/util/VersionUtilTest.java
@@ -1,6 +1,7 @@
 package com.firebolt.jdbc.util;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import org.junit.jupiter.api.Test;
 
@@ -13,12 +14,13 @@ void shouldGetDriverMajorVersion() {
 
 	@Test
 	void shouldGetDriverMinorVersion() {
-		assertEquals(5, VersionUtil.getDriverMinorVersion());
+		int minorVersion = VersionUtil.getDriverMinorVersion();
+		assertTrue(minorVersion >= 0 && minorVersion < 100);
 	}
 
 	@Test
 	void shouldGetProjectVersion() {
-		assertEquals("3.5.0", VersionUtil.getDriverVersion());
+		assertTrue(VersionUtil.getDriverVersion().matches("3\\.\\d+\\.\\d+"));
 	}
 
 	@Test