ci: Fix secrets in release action (#324)

firebolt-db · Nov 27, 2023 · 31e558d · 31e558d
1 parent bb1dc73
commit 31e558d
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 22 deletions.
diff --git a/.github/workflows/integration-tests-v1.yml b/.github/workflows/integration-tests-v1.yml
@@ -16,10 +16,6 @@ on:
         default: 'staging'
         required: false
         type: string
-      branch:
-        required: false
-        type: string
-        description: 'Branch to run on'
     secrets:
       FIREBOLT_USERNAME:
         required: true
@@ -33,14 +29,16 @@ on:
         required: true
       SERVICE_SECRET:
         required: true
+      SERVICE_ID_STG:
+        required: true
+      SERVICE_SECRET_STG:
+        required: true
 jobs:
   tests:
     runs-on: ubuntu-latest
     steps:
       - name: Check out code
         uses: actions/checkout@v2
-        with:
-          ref: ${{ inputs.branch }}
 
       - name: Set up Python 3.7
         uses: actions/setup-python@v2
@@ -62,8 +60,8 @@ jobs:
           else
               echo "USERNAME=${{ secrets.FIREBOLT_USERNAME }}" >> "$GITHUB_ENV"
               echo "PASSWORD=${{ secrets.FIREBOLT_PASSWORD }}" >> "$GITHUB_ENV"
-              echo "CLIENT_ID=${{ secrets.FIREBOLT_CLIENT_ID }}" >> "$GITHUB_ENV"
-              echo "CLIENT_SECRET=${{ secrets.FIREBOLT_CLIENT_SECRET }}" >> "$GITHUB_ENV"
+              echo "CLIENT_ID=${{ secrets.SERVICE_ID }}" >> "$GITHUB_ENV"
+              echo "CLIENT_SECRET=${{ secrets.SERVICE_SECRET }}" >> "$GITHUB_ENV"
           fi
 
       - name: Setup database and engine

diff --git a/.github/workflows/integration-tests-v2.yml b/.github/workflows/integration-tests-v2.yml
@@ -16,10 +16,6 @@ on:
         default: 'staging'
         required: false
         type: string
-      branch:
-        required: false
-        type: string
-        description: 'Branch to run on'
     secrets:
       FIREBOLT_CLIENT_ID_STG_NEW_IDN:
         required: true
@@ -35,8 +31,6 @@ jobs:
     steps:
       - name: Check out code
         uses: actions/checkout@v2
-        with:
-          ref: ${{ inputs.branch }}
 
       - name: Set up Python 3.7
         uses: actions/setup-python@v2

diff --git a/.github/workflows/integration-tests.yml b/.github/workflows/integration-tests.yml
@@ -16,10 +16,6 @@ on:
         default: 'staging'
         required: false
         type: string
-      branch:
-        required: false
-        type: string
-        description: 'Branch to run on'
     secrets:
       FIREBOLT_USERNAME:
         required: true
@@ -33,6 +29,10 @@ on:
         required: true
       SERVICE_SECRET:
         required: true
+      SERVICE_ID_STG:
+        required: true
+      SERVICE_SECRET_STG:
+        required: true
       # V2 secrets
       FIREBOLT_CLIENT_ID_STG_NEW_IDN:
         required: true
@@ -46,20 +46,20 @@ jobs:
   integration-test-v1:
     uses: ./.github/workflows/integration-tests-v1.yml
     with:
-      environment: ${{ github.event.inputs.environment }}
-      branch: ${{ github.event.inputs.branch }}
+      environment: ${{ inputs.environment }}
     secrets:
       FIREBOLT_USERNAME: ${{ secrets.FIREBOLT_USERNAME }}
       FIREBOLT_PASSWORD: ${{ secrets.FIREBOLT_PASSWORD }}
       FIREBOLT_STG_USERNAME: ${{ secrets.FIREBOLT_STG_USERNAME }}
       FIREBOLT_STG_PASSWORD: ${{ secrets.FIREBOLT_STG_PASSWORD }}
       SERVICE_ID: ${{ secrets.SERVICE_ID }}
       SERVICE_SECRET: ${{ secrets.SERVICE_SECRET }}
+      SERVICE_ID_STG: ${{ secrets.SERVICE_ID_STG }}
+      SERVICE_SECRET_STG: ${{ secrets.SERVICE_SECRET_STG }}
   integration-test-v2:
     uses: ./.github/workflows/integration-tests-v2.yml
     with:
-      environment: ${{ github.event.inputs.environment }}
-      branch: ${{ github.event.inputs.branch }}
+      environment: ${{ inputs.environment }}
     secrets:
       FIREBOLT_CLIENT_ID_STG_NEW_IDN: ${{ secrets.FIREBOLT_CLIENT_ID_STG_NEW_IDN }}
       FIREBOLT_CLIENT_SECRET_STG_NEW_IDN: ${{ secrets.FIREBOLT_CLIENT_SECRET_STG_NEW_IDN }}

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -13,6 +13,8 @@ on:
 jobs:
   integration-tests:
     uses: ./.github/workflows/integration-tests.yml
+    with:
+      environment: "staging"
     secrets:
       FIREBOLT_CLIENT_ID_STG_NEW_IDN: ${{ secrets.FIREBOLT_CLIENT_ID_STG_NEW_IDN }}
       FIREBOLT_CLIENT_SECRET_STG_NEW_IDN: ${{ secrets.FIREBOLT_CLIENT_SECRET_STG_NEW_IDN }}
@@ -24,6 +26,8 @@ jobs:
       FIREBOLT_STG_PASSWORD: ${{ secrets.FIREBOLT_STG_PASSWORD }}
       SERVICE_ID: ${{ secrets.SERVICE_ID }}
       SERVICE_SECRET: ${{ secrets.SERVICE_SECRET }}
+      SERVICE_ID_STG: ${{ secrets.SERVICE_ID_STG }}
+      SERVICE_SECRET_STG: ${{ secrets.SERVICE_SECRET_STG }}
 
   publish:
     runs-on: ubuntu-latest