fix: ignore empty parts in multistatement queries (#97)

firebolt-db · Jun 19, 2024 · e3a3380 · e3a3380
1 parent ad53156
commit e3a3380
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/utils.go b/utils.go
@@ -120,6 +120,9 @@ func SplitStatements(sql string) ([]string, error) {
 		if err != nil {
 			return nil, ConstructNestedError("error during splitting query", err)
 		}
+		if strings.Trim(query, " \t\n") == "" {
+			continue
+		}
 		queries = append(queries, query)
 	}
 

diff --git a/utils_test.go b/utils_test.go
@@ -180,8 +180,9 @@ func runSplitStatement(t *testing.T, value string, expected []string) {
 func TestSplitStatements(t *testing.T) {
 	runSplitStatement(t, "SELECT 1; SELECT 2;", []string{"SELECT 1", " SELECT 2"})
 	runSplitStatement(t, "SELECT 1;", []string{"SELECT 1"})
+	runSplitStatement(t, "SELECT 1; ", []string{"SELECT 1"})
 	runSplitStatement(t, "SELECT 1", []string{"SELECT 1"})
-	runSplitStatement(t, "SELECT 1; ; ; ; ", []string{"SELECT 1", " ", " ", " ", " "})
+	runSplitStatement(t, "SELECT 1; ; ; ; ", []string{"SELECT 1"})
 
 	runSplitStatement(t, "SET time_zone=America/New_York; SELECT 2 /*some ; comment*/", []string{"SET time_zone=America/New_York", " SELECT 2 /*some ; comment*/"})
 	runSplitStatement(t, "SET time_zone='America/New_York'; SELECT 2 /*some ; comment*/", []string{"SET time_zone='America/New_York'", " SELECT 2 /*some ; comment*/"})