test(FIR-35179): re-enable some of the fixed tests (#144)

firebolt-db · Sep 10, 2024 · e3c5450 · e3c5450
1 parent 5beda41
commit e3c5450
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/.changes/unreleased/Changed-20240909-160913.yaml b/.changes/unreleased/Changed-20240909-160913.yaml
@@ -0,0 +1,3 @@
+kind: Changed
+body: Enabled tests that were disabled due to the feature gaps
+time: 2024-09-09T16:09:13.607541+01:00
diff --git a/tests/functional/adapter/test_basic.py b/tests/functional/adapter/test_basic.py
@@ -157,7 +157,6 @@ class TestSnapshotTimestampFirebolt(BaseSnapshotTimestamp):
     pass
 
 
-@mark.skip('Firebolt has a bug in LEFT JOIN. FIR-11078')
 class TestBaseAdapterMethod(BaseAdapterMethod):
     pass
 

diff --git a/tests/functional/adapter/utils/test_data_types.py b/tests/functional/adapter/utils/test_data_types.py
@@ -114,7 +114,6 @@ def models(self):
         }
 
 
-@pytest.mark.skip('True boolean is feature-flagged')
 class TestTypeBoolean(BaseTypeBoolean):
     @pytest.fixture(scope='class')
     def models(self):

diff --git a/tests/functional/adapter/utils/test_utils.py b/tests/functional/adapter/utils/test_utils.py
@@ -280,12 +280,12 @@ def models(self):
         }
 
 
-@mark.skip('Escaping with backslash is not supported in Firebolt')
+@mark.skip('Escaping with backslash is not supported by default in Firebolt')
 class TestEscapeSingleQuotes(BaseEscapeSingleQuotesBackslash):
     pass
 
 
-@mark.skip('Except is not supported yet')
+@mark.skip('Except is not supported yet. FIR-16223')
 class TestExcept(BaseExcept):
     pass
 
@@ -313,7 +313,7 @@ def models(self):
         }
 
 
-@mark.skip('Intersect is not supported yet')
+@mark.skip('Intersect is not supported yet. FIR-16223')
 class TestIntersect(BaseIntersect):
     pass
-Original file line number
+Diff line change
@@ Expand Up / @@ -157,7 +157,6 @@ class TestSnapshotTimestampFirebolt(BaseSnapshotTimestamp): @@
         pass
-    @mark.skip('Firebolt has a bug in LEFT JOIN. FIR-11078')
     class TestBaseAdapterMethod(BaseAdapterMethod):
         pass
@@ Expand Down @@