feat(functions): Swift Package Manager support #16770
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyokone
approved these changes
Nov 26, 2024
Comment on lines
+20
to
+37
| func loadFirebaseSDKVersion() throws -> String { | ||
| let firebaseCoreScriptPath = NSString.path(withComponents: [ | ||
| functionsDirectory, | ||
| "..", | ||
| "..", | ||
| "ios", | ||
| "generated_firebase_sdk_version.txt", | ||
| ]) | ||
| do { | ||
| let version = try String(contentsOfFile: firebaseCoreScriptPath, encoding: .utf8) | ||
| .trimmingCharacters(in: .whitespacesAndNewlines) | ||
| return version | ||
| } catch { | ||
| throw ConfigurationError | ||
| .fileNotFound("Error loading or parsing generated_firebase_sdk_version.txt: \(error)") | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Do you think this could be shared between different plugins? Or is this generated for each one?
There was a problem hiding this comment.
It's not possible in a clean way. Can't import local files into Package.swift and can't specify a dependency to be used in Package.swift 😔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?