Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(firebase_core): create a swift package of shared iOS source code for all plugins #13540

Merged
merged 7 commits into from
Oct 23, 2024

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Oct 23, 2024

Description

  • created a firebase core shared package in the root of FlutterFire repo for source code that is shared between all plugins. this will be pulled in by all plugins including firebase core. Symlinked code that is shared into Sources/ directory in the root of repo.
  • created a script that tags ${firebase-core-version}-firebase-core-swift so we can keep it up-to-date.

I've tested this with my own FlutterFire fork so I think once I tag main branch by running the [generate_tag_spm_firebase_core.dart manually, I should be able to use it in the SPM firestore PR, and get that ready for review.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley changed the title feat(firebase_core): create a swift package of shared iOS source code for all plugins chore(firebase_core): create a swift package of shared iOS source code for all plugins Oct 23, 2024
@russellwheatley russellwheatley merged commit 7376043 into main Oct 23, 2024
29 of 30 checks passed
@russellwheatley russellwheatley deleted the prepare-core-swift branch October 23, 2024 11:24
@firebase firebase locked and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants