Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fdc): Updated to allow for sdktype to be set (core vs gen) #13392

Merged
merged 8 commits into from
Sep 25, 2024
Merged

feat(fdc): Updated to allow for sdktype to be set (core vs gen) #13392

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
08dfe5e
Updated to allow for sdktype
maneesht Sep 24, 2024
12fc483
Fixed tests
maneesht Sep 24, 2024
0f30aea
Updated headers to use dart instead of flutter
maneesht Sep 24, 2024
600f922
Wrote tests and renamed enum
maneesht Sep 24, 2024
d588d13
Used proper gl-dart
maneesht Sep 24, 2024
c029a7b
Merge remote-tracking branch 'origin/main' into mtewani/add-caller-type
maneesht Sep 25, 2024
07c855b
Added generation changes
maneesht Sep 25, 2024
88c803c
Fixed typo
maneesht Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/firebase_data_connect/firebase_data_connect/lib/src/common/common_library.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ part 'dataconnect_options.dart';
enum CallerSDKType { core, generated }

String getGoogApiVal(CallerSDKType sdkType, String packageVersion) {
String apiClientValue = 'gl-dart/flutter fire/$packageVersion';
String apiClientValue = 'gl-dart/$packageVersion fire/$packageVersion';
maneesht marked this conversation as resolved.
Show resolved Hide resolved
if (sdkType == CallerSDKType.generated) {
apiClientValue += ' dart/gen';
}
Expand Down
4 changes: 2 additions & 2 deletions ...ages/firebase_data_connect/firebase_data_connect/test/src/common/common_library_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@ void main() {
test('should return no codegen suffix if using core sdk', () {
final packageVersion = "1.0.0";
expect(getGoogApiVal(CallerSDKType.core, packageVersion),
'gl-dart/flutter fire/$packageVersion');
'gl-dart/$packageVersion fire/$packageVersion');
});
test('should return codegen suffix if using gen sdk', () {
final packageVersion = "1.0.0";
expect(getGoogApiVal(CallerSDKType.generated, packageVersion),
'gl-dart/flutter fire/$packageVersion dart/gen');
'gl-dart/$packageVersion fire/$packageVersion dart/gen');
});
});
group('TransportOptions', () {
Expand Down
Loading