-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(firestore): Swift Package Manager support #13329
Conversation
await buildSwiftExampleApp('ios', 'firebase_core'); | ||
await buildSwiftExampleApp('ios', 'cloud_firestore'); | ||
await buildSwiftExampleApp('macos', 'firebase_core'); | ||
await buildSwiftExampleApp('macos', 'cloud_firestore'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will we need to do the other packages? Or is it just because cloud_firestore has its own SPM package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's just for the packages which have Swift support; core + firestore.
Description
Package.swift
to negate duplicate symbols: https://github.com/firebase/flutterfire/pull/13329/files#diff-8ba779f9dea534ccdcb7bea8d78060e805ad75ef984ad7ce64d49c947ab76f16R111-R114Package.swift
file. E.g: https://github.com/firebase/flutterfire/pull/13329/files#diff-8ba779f9dea534ccdcb7bea8d78060e805ad75ef984ad7ce64d49c947ab76f16R99melos version
: https://github.com/firebase/flutterfire/blob/main/melos.yaml#L25git push --tags
. Tag looks like3.6.0-firebase-core-swift
. I would've like to use existing firebase core tag but it isn't semantically correct as Swift requires version first whilst our current tag looks likefirebase_core-v3.6.0
(i.e. version last).generated_firebase_sdk_version.txt
file if the package has aPackage.swift
file (i.e. supports Swift), it also ignore firebase_core plugin as it already has the canonicalfirebase_sdk_version.rb
version file.Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?