fix: nil pointer dereference fix #132 #135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfaller
reviewed
Jul 24, 2020
| @@ -1369,24 +1369,26 @@ func (ge *goEncoder) genGoOpStruct(w io.Writer, d *wsdl.Definitions, bo *wsdl.Bi | |||
| name := goSymbol(bo.Name) | |||
| function := ge.funcs[name] | |||
There was a problem hiding this comment.
function := ge.funcs[name] should be function := ge.funcs[bo.Name] and the whole issue is fixed.
No other changes are required.
There was a problem hiding this comment.
No, this fix doesn't seem to work with other wsdls, unfortunately :(
|
I've created another PR (#137) since this one wasn't working properly for all the test cases and was polluting the stdout. The fix should now work. Replacing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should hopefully fix the bug introduced in the previous commit.
I've added the two use cases and now the tests are passing. This should hopefully be the definitive fix for making #132 work and #131