Revert "Bugfix: Dispose process handle."

This reverts commit a153a89.
fintermobilityas · May 22, 2022 · 50b9249 · 50b9249
1 parent 310ed2c
commit 50b9249
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/src/Snap/AnyOS/SnapOsProcessManager.cs b/src/Snap/AnyOS/SnapOsProcessManager.cs
@@ -104,7 +104,7 @@ public SnapOsProcess Build(int pid, string name, string workingDirectory = defau
 
     static async Task<(int exitCode, string standardOutput)> RunAsync(ProcessStartInfo processStartInfo, CancellationToken cancellationToken)
     {
-        using var process = Process.Start(processStartInfo);
+        var process = Process.Start(processStartInfo);
         if (process == null)
         {
             throw new Exception($"Error invoking process: {processStartInfo.FileName}. Arguments: {processStartInfo.Arguments}");

diff --git a/src/Snap/Core/SnapInstaller.cs b/src/Snap/Core/SnapInstaller.cs
@@ -389,7 +389,7 @@ async Task InvokeSnapApps([NotNull] List<ProcessStartInfoBuilder> allSnapAwareAp
                 .Add($"--snapx-first-run {semanticVersion.ToNormalizedString()}");
             try
             {
-                using var _ = _snapOs.ProcessManager
+                _snapOs.ProcessManager
                     .StartNonBlocking(builder);
             }
             catch (Exception ex)

diff --git a/src/Snap/Core/Snapx.cs b/src/Snap/Core/Snapx.cs
@@ -202,7 +202,6 @@ public static bool StartSupervisor(List<string> restartArguments = null)
 
         var coreRunArgument = $"--corerun-supervise-pid={SnapOs.ProcessManager.Current.Id} --corerun-supervise-id={superVisorId}";
 
-        SuperVisorProcess?.Dispose();
         SuperVisorProcess = SnapOs.ProcessManager.StartNonBlocking(new ProcessStartInfoBuilder(SuperVisorProcessExeDirectory)
             .AddRange(restartArguments ?? new List<string>())
             .Add(coreRunArgument)