Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review legend compile pmcd #3212

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Conversation

hbalasu2
Copy link
Contributor

What type of PR is this?

Improvement

What does this PR do / why is it needed ?

Adding support and exposing compile PMCD method for testing protocols from Pure light IDE

@hbalasu2 hbalasu2 requested a review from a team as a code owner October 29, 2024 05:02
Copy link
Contributor

@gs-jp1 gs-jp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing is to adjust the copyright year
We should also consider if further test cases should be added.

@gs-jp1 gs-jp1 merged commit dea7680 into finos:master Oct 29, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants