Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not evaluate default value constructors #3174

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Do not evaluate default value constructors #3174

merged 1 commit into from
Nov 4, 2024

Conversation

mateusz-klatt
Copy link
Member

@mateusz-klatt mateusz-klatt commented Oct 13, 2024 •
edited
Loading

What type of PR is this?

  • Improvement

What does this PR do / why is it needed?

  • Use reflection in diff generator to find out arguments to constructors, so the is no need to compile Java Impl classes for Pure entities.
  • Improve Change Tokens development cycle, allow to test code in Pure IDE (move unit tests from Java to Pure)

Other notes for reviewers:

Pending regression checks in integration enviroment.

@mateusz-klatt mateusz-klatt requested a review from a team as a code owner October 13, 2024 01:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 15, 2024 •
edited
Loading

Test Results

  1 014 files    1 014 suites   1h 40m 56s ⏱️
12 686 tests 12 577 ✔️ 109 💤 0 ❌
18 673 runs  18 564 ✔️ 109 💤 0 ❌

Results for commit 3e36852.

♻️ This comment has been updated with latest results.

@mateusz-klatt mateusz-klatt force-pushed the bugfix branch 7 times, most recently from d737f5c to e002f8c Compare October 20, 2024 11:13
@mateusz-klatt mateusz-klatt force-pushed the bugfix branch 8 times, most recently from a772f74 to d7e7f65 Compare October 29, 2024 14:17
@mateusz-klatt mateusz-klatt force-pushed the bugfix branch 11 times, most recently from 2a018d9 to 965baeb Compare November 1, 2024 22:21
@kevin-m-knight-gs kevin-m-knight-gs merged commit 0c3f637 into finos:master Nov 4, 2024
5 of 6 checks passed
@mateusz-klatt mateusz-klatt deleted the bugfix branch November 4, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-m-knight-gs kevin-m-knight-gs kevin-m-knight-gs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mateusz-klatt @kevin-m-knight-gs