Legend SQL - add to_char, lpad, rpad #2454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. add lpad/rpad 2. remove deprecated sql classes 3. added lpad/rpad pure string functions 4. added pure2sql support for month 5. more dialect handling of month/dayofweek
gs-jp1
requested review from
a team,
pierredebelen,
epsstan,
davidharte-gs,
gs-ssh16,
rafaelbey and
aormerod-gs
as code owners
aormerod-gs
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Improvement
What does this PR do / why is it needed ?
Which issue(s) this PR fixes:
Other notes for reviewers:
Does this PR introduce a user-facing change?