Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Snowflake Reserved Words to Extension file #2444

Merged
merged 5 commits into from
Nov 10, 2023
Merged

Conversation

sprisha
Copy link
Contributor

@sprisha sprisha commented Nov 7, 2023

What type of PR is this?

Improvement

What does this PR do / why is it needed ?

Adding snowflake reserved words to extension file

Which issue(s) this PR fixes:

Fixes #

Other notes for reviewers:

Does this PR introduce a user-facing change?

Yes, they will be able to create better/executable sql queries

@sprisha sprisha requested a review from a team as a code owner November 7, 2023 19:21
@sprisha
Copy link
Contributor Author

sprisha commented Nov 7, 2023

/easycla

Copy link

github-actions bot commented Nov 7, 2023

Test Results

     702 files  ±0       702 suites  ±0   1h 1m 20s ⏱️ -22s
11 534 tests +2  11 150 ✔️ +2  384 💤 ±0  0 ±0 
14 432 runs  +2  13 964 ✔️ +2  468 💤 ±0  0 ±0 

Results for commit bff4789. ± Comparison against base commit 5737489.

♻️ This comment has been updated with latest results.

aormerod-gs
aormerod-gs previously approved these changes Nov 8, 2023
…tore-dbExtension/legend-engine-xt-relationalStore-postgres/legend-engine-xt-relationalStore-postgres-pure/src/main/resources/core_relational_postgres/relational/sqlQueryToString/postgresExtension.pure
@Yasirmod17 Yasirmod17 merged commit fc4c7f5 into finos:master Nov 10, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants