Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relational - sortBy deep path #2441

Closed
wants to merge 1 commit into from

Conversation

abhishoya-gs
Copy link
Contributor

What type of PR is this?

Improvement

What does this PR do / why is it needed ?

Handling deep paths in sortBy

Which issue(s) this PR fixes:

Fixes #

Other notes for reviewers:

Does this PR introduce a user-facing change?

Yes, now they will be able to pass in nested paths

@abhishoya-gs abhishoya-gs requested a review from a team as a code owner November 7, 2023 10:21
@abhishoya-gs abhishoya-gs self-assigned this Nov 7, 2023
@abhishoya-gs abhishoya-gs requested a review from gs-ssh16 November 7, 2023 10:21
@abhishoya-gs abhishoya-gs changed the title sortBy deep path relational - sortBy deep path Nov 7, 2023
Copy link

github-actions bot commented Nov 7, 2023

Test Results

     702 files  ±0       702 suites  ±0   1h 1m 23s ⏱️ -19s
11 534 tests +2  11 150 ✔️ +2  384 💤 ±0  0 ±0 
14 432 runs  +2  13 964 ✔️ +2  468 💤 ±0  0 ±0 

Results for commit d06677a. ± Comparison against base commit 5737489.

@abhishoya-gs abhishoya-gs marked this pull request as draft November 7, 2023 16:16
@abhishoya-gs abhishoya-gs marked this pull request as ready for review November 8, 2023 10:22
@finos-admin
Copy link
Member

This PR is stale because it has been open for 30 days with no activity. Please remove stale label or add any comment to keep this open. Otherwise this will be closed in 5 days.

@finos-admin
Copy link
Member

This PR was closed because it has been inactive for 35 days. Please re-open if this PR is still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants