Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data-push: POC server #2368

Merged
merged 22 commits into from
Nov 16, 2023
Merged

data-push: POC server #2368

merged 22 commits into from
Nov 16, 2023

Conversation

akphi
Copy link
Contributor

@akphi akphi commented Oct 13, 2023 •
edited
Loading

NOTE

This PR only includes the model change and the push-server glue code, the migration change will be done in a different PR, but this is the rough demo:

A Snowflake connection using KeyPair is automatically converted/deserialized to use the new connection models and therefore connection is acquired using the new framework

Screen.Recording.2023-11-14.at.4.32.53.PM.mov

@github-actions
Copy link

github-actions bot commented Oct 13, 2023 •
edited
Loading

Test Results

     703 files  ±0       703 suites  ±0   1h 1m 31s ⏱️ +10s
11 635 tests  - 1  11 230 ✔️  - 2  405 💤 +1  0 ❌ ±0 
14 533 runs   - 1  14 044 ✔️  - 2  489 💤 +1  0 ❌ ±0 

Results for commit 4522f34. ± Comparison against base commit 84c62a1.

♻️ This comment has been updated with latest results.

@akphi akphi force-pushed the psh branch 8 times, most recently from 668695c to 95a00da Compare October 18, 2023 04:27
@akphi akphi force-pushed the psh branch 9 times, most recently from 1236809 to d2cd3a6 Compare November 2, 2023 00:01
@akphi akphi force-pushed the psh branch 3 times, most recently from d08530c to d207c32 Compare November 7, 2023 23:23
@akphi akphi force-pushed the psh branch 3 times, most recently from 030beaa to 0f5afed Compare November 14, 2023 08:26
@akphi akphi marked this pull request as ready for review November 14, 2023 21:20
epsstan
epsstan requested changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@epsstan epsstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See conversation.

@epsstan epsstan merged commit 0060453 into finos:master Nov 16, 2023
3 checks passed
@akphi akphi deleted the psh branch November 16, 2023 14:56
@akphi akphi mentioned this pull request Nov 16, 2023
Closed
MauricioUyaguari pushed a commit to MauricioUyaguari/legend-engine that referenced this pull request Nov 16, 2023
@akphi @MauricioUyaguari
data-push: POC server (finos#2368)
4b0224e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epsstan epsstan epsstan approved these changes

@pierredebelen pierredebelen Awaiting requested review from pierredebelen

@davidharte-gs davidharte-gs Awaiting requested review from davidharte-gs

@gs-ssh16 gs-ssh16 Awaiting requested review from gs-ssh16

@rafaelbey rafaelbey Awaiting requested review from rafaelbey

@aormerod-gs aormerod-gs Awaiting requested review from aormerod-gs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akphi @epsstan