add allowed_extensions setting #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #216 +/- ##
==========================================
+ Coverage 65.88% 65.90% +0.02%
==========================================
Files 6 6
Lines 85 88 +3
Branches 12 13 +1
==========================================
+ Hits 56 58 +2
- Misses 26 27 +1
Partials 3 3
|
timkpaine
commented
Jun 28, 2023
| @@ -103,22 +103,29 @@ function activate(app, menu, browser, launcher) { | |||
| const {path} = browser.defaultBrowser.model; | |||
|
|
|||
| return new Promise((resolve) => { | |||
| const ext = data.filename.split(".").pop().toLowerCase(); | |||
There was a problem hiding this comment.
I bet there's something in the JupyterLab packages to do this
|
@timkpaine Thanks for rebasing + tweaking + merging this! Is this something you'd be willing to create a new release for? Currently, we've got our fork building a wheel for us to vendor - but I'd love to get our builds swapped back to just using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebased and tweaked #215