Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in fixes to control definitions #570

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

mlysaght2017
Copy link
Contributor

No description provided.

@mlysaght2017 mlysaght2017 requested a review from a team as a code owner November 27, 2024 10:36
@mlysaght2017
Copy link
Contributor Author

mlysaght2017 commented Nov 27, 2024

@sarahecraddock - this PR addresses the tweaks needed based on our weekly discussion:

  1. CCC.C07 -> generalize to unusual enumeration activity
  2. CCC.C08 -> Rephrasing to remove explicit mention of admin
  3. CCC.ObjStor.C02 -> Rephrasing to remove explicit mention of admin
  4. CCC.ObjStor.C07 -> change bucket to "data store"

Copy link

@sarahecraddock sarahecraddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @mlysaght2017, just one suggestion that I spotted where the admin user language is used in a similar way that it might be worth updating to align with the others you updated 😊

@mlysaght2017
Copy link
Contributor Author

@damienjburks - can you please approve and merge - thanks

@damienjburks damienjburks merged commit 1c43470 into finos:main Nov 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants