Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#534: Add yaml linter #542

Closed

Conversation

dogle-scottlogic
Copy link
Contributor

@dogle-scottlogic dogle-scottlogic commented Nov 15, 2024

Add yamllint as a workflow job to ensure the yaml files are consistent with the markdown.

Addresses issue #534

There are quite a few fails for the linter so I'll address those in a different PR

@dogle-scottlogic dogle-scottlogic requested a review from a team as a code owner November 15, 2024 11:02
@dogle-scottlogic dogle-scottlogic requested a review from a team as a code owner November 15, 2024 11:04
@dogle-scottlogic dogle-scottlogic force-pushed the CCC-535-yaml-linting branch 3 times, most recently from d4a71db to 3112d65 Compare November 15, 2024 11:07
@eddie-knight
Copy link
Contributor

Looks like the linter works, and integrates with GitHub in-line comments! Nice!

Screenshot 2024-11-15 at 06 53 47

For this case, though... I noticed that this yaml isn't following the style that it enforces 😆

Are we sure we want to force ourselves to go back and add it to every file? I could go either way— just depends on whether this is adding value.

@dogle-scottlogic
Copy link
Contributor Author

dogle-scottlogic commented Nov 15, 2024

@eddie-knight

Are we sure we want to force ourselves to go back and add it to every file? I could go either way— just depends on whether this is adding value.

Yeah - I'm just finishing off fixing the errors on a separate branch. I've changed the settings to ignore the .config folder and extend the relaxed rule-set to make things a bit easier

@dogle-scottlogic dogle-scottlogic added the community structure Work related to the Community Structure WG label Nov 15, 2024
@damienjburks
Copy link
Contributor

damienjburks commented Nov 17, 2024

@dogle-scottlogic should we close this PR?

@dogle-scottlogic
Copy link
Contributor Author

@damienjburks - yeah we can do. I guess I had originally intended to keep adding the linter and fixing the issues as two separate commits just to keep it a bit neater but I don't think there's a huge amount of value in it as this one is pretty small. I close it down 😄.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community structure Work related to the Community Structure WG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants