Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
eddie-knight authored Dec 13, 2024
1 parent b6b9178 commit 39eaa65
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions services/database/warehouse/features.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ features:
- id: CCC.DataWar.F01 # Dataset Management
title: Dataset Management
description: |
Provides the ability to create, manage, and organize
Provides the ability to create, manage, and organize
datasets within the Cloud Data Warehouse for structured
data storage.
# references: # Temporary for validation purposes
Expand All @@ -42,7 +42,8 @@ features:
description: |
Allows setting access policies at the column level to restrict access to sensitive data fields within tables.
# references:

Check failure on line 44 in services/database/warehouse/features.yaml

View workflow job for this annotation

GitHub Actions / yaml-checker / yaml-check

All mapping items must start at the same column YAML.

All mapping items must start at the same column Complete description of the feature Source: features-schema.json (schemas/features-schema.json)
# AWS: https://aws.amazon.com/blogs/big-data/achieve-finer-grained-data-security-with-column-level-access-control-in-amazon-redshift/
# AWS: https://aws.amazon.com/blogs/big-data/achieve-finer-grained-data-
security-with-column-level-access-control-in-amazon-redshift/

Check failure on line 46 in services/database/warehouse/features.yaml

View workflow job for this annotation

GitHub Actions / run-linting-check / yaml-lint

46:6 syntax error: expected <block end>, but found '<scalar>' (syntax)

Check failure on line 46 in services/database/warehouse/features.yaml

View workflow job for this annotation

GitHub Actions / yaml-checker / yaml-check

Implicit map keys need to be followed by map values YAML.

Implicit map keys need to be followed by map values
# GCP: https://cloud.google.com/bigquery/docs/column-level-security
# Azure: https://learn.microsoft.com/en-us/azure/synapse-analytics/sql-data-warehouse/column-level-security

Expand All @@ -56,4 +57,5 @@ features:
# references:

Check failure on line 57 in services/database/warehouse/features.yaml

View workflow job for this annotation

GitHub Actions / yaml-checker / yaml-check

All mapping items must start at the same column YAML.

All mapping items must start at the same column Complete description of the feature Source: features-schema.json (schemas/features-schema.json)
# AWS: https://docs.aws.amazon.com/redshift/latest/dg/t_rls.html
# GCP: https://cloud.google.com/bigquery/docs/row-level-security-intro
# Azure: https://techcommunity.microsoft.com/t5/azure-synapse-analytics-blog/how-to-implement-row-level-security-in-serverless-sql-pools/ba-p/2354759
# Azure: https://techcommunity.microsoft.com/t5/azure-synapse-analytics-
blog/how-to-implement-row-level-security-in-serverless-sql-pools/ba-p/2354759

Check failure on line 61 in services/database/warehouse/features.yaml

View workflow job for this annotation

GitHub Actions / run-linting-check / yaml-lint

61:6 [indentation] wrong indentation: expected 4 but found 5

Check failure on line 61 in services/database/warehouse/features.yaml

View workflow job for this annotation

GitHub Actions / yaml-checker / yaml-check

Implicit map keys need to be followed by map values YAML.

Implicit map keys need to be followed by map values

0 comments on commit 39eaa65

Please sign in to comment.