Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#446 - Upgrade CLI to 2024-10. #696

Merged
merged 2 commits into from
Dec 20, 2024
Merged

#446 - Upgrade CLI to 2024-10. #696

merged 2 commits into from
Dec 20, 2024

Conversation

Thels
Copy link
Member

@Thels Thels commented Dec 20, 2024

For now this is only ensuring that the draft version is updated - not that the examples/functionality exposed by the upgraded CALM version would provide - these are covered by other issues.

For now this is only ensuring that the draft version is updated - not that the examples/functionality exposed by the upgraded CALM version would provide - these are covered by other issues.
@rocketstack-matt
Copy link
Member

Is the version in shared/package.json expected to be kept in sync with the cli? What about the workspace version? Do we need / want to adopt a convention here?

Copy link
Member

@rocketstack-matt rocketstack-matt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version should be updated in cli/src/index.ts

shared/src/commands/validate/validate.spec.ts Outdated Show resolved Hide resolved
shared/src/commands/validate/validate.spec.ts Outdated Show resolved Hide resolved
@Thels
Copy link
Member Author

Thels commented Dec 20, 2024

Is the version in shared/package.json expected to be kept in sync with the cli? What about the workspace version? Do we need / want to adopt a convention here?

It doesn't need to be kept in sync -the version within shared is effectively moot as it's a non-published package.

@Thels
Copy link
Member Author

Thels commented Dec 20, 2024

version should be updated in cli/src/index.ts

Good spot - I've included resolving it directly from the package.json - as keeping this one up to date manually would be a pain.

@rocketstack-matt
Copy link
Member

version should be updated in cli/src/index.ts

Good spot - I've included resolving it directly from the package.json - as keeping this one up to date manually would be a pain.

Unless you've figured out a new way, this won't work - see this thread - #283

@Thels
Copy link
Member Author

Thels commented Dec 20, 2024

version should be updated in cli/src/index.ts

Good spot - I've included resolving it directly from the package.json - as keeping this one up to date manually would be a pain.

Unless you've figured out a new way, this won't work - see this thread - #283

I have! It's included in both the TS config and the bundler is handling it for us.

It inlines var version = "0.3.0"; into the disted artifact that is published/ran as the CLI.

@rocketstack-matt
Copy link
Member

version should be updated in cli/src/index.ts

Good spot - I've included resolving it directly from the package.json - as keeping this one up to date manually would be a pain.

Unless you've figured out a new way, this won't work - see this thread - #283

I have! It's included in both the TS config and the bundler is handling it for us.

It inlines var version = "0.3.0"; into the disted artifact that is published/ran as the CLI.

Awesome!

@rocketstack-matt rocketstack-matt self-requested a review December 20, 2024 13:04
@rocketstack-matt rocketstack-matt merged commit 7e2a717 into finos:main Dec 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants