Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add data plots and add create expense #11

Merged
merged 9 commits into from
Dec 27, 2023
Merged

Conversation

nicolasauler
Copy link
Collaborator

@nicolasauler nicolasauler commented Dec 25, 2023

Added Expense over Time plot to index page.
Also, added creating expense functionality to frontend. Now user can manually add an expense, which is located in a modal.

More things done:

  • Getting expenses and plots on page load

⚠️ I forked plotly, because plotly has askama as dependency, but without with-axum feature flag, that creates a clash with the dependencies of finnish. So I forked it and added askama_axum as a dependency there.
This it definitely not optimal, but such is life ⚠️

TODO:

  • Close modal upon clicking outside of it
  • Maybe whenever an expense is created, the table and plot could be changed to whatever month the added expense was attributed to. Idk, though

Also began expense creation in htmx.
However, a few bugs came up:
- When we create an expense, search and edit become not functional and
  break everything.
- When we create an expense, it should trigger a get in the month issued
  in the request to show now all expenses.
- Also, if we click outside the modal, it doesn't work, modal isn't
  closed.
TODO: include created expense date in table GET. This way, we would be
able to apply logic to maybe change to the month of the created date.
Idk
@nicolasauler nicolasauler self-assigned this Dec 25, 2023
Needed because of dependency clashes with upstream plotly: later make a
PR.
This reverts commit 97a0e83.
This way I can fix the dependency clashes with the deps of plotly.
This is not supposed to be a permanent fix, though.
confused when it comes to decimal separator.
@nicolasauler nicolasauler merged commit 672c21b into main Dec 27, 2023
2 checks passed
@nicolasauler nicolasauler deleted the feat-data-plots branch December 27, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant