Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate package-lock & sort package.json #166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Saibamen
Copy link
Contributor

  1. Recreate package-lock.json by deleting this file and node_modules folder and running npm install again
  2. Run npx sort-package-json

Copy link
Member

@Arsenicro Arsenicro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bad news is that it seems to be breaking our app: I see multiple errors when running it (Element type is invalid and process is not defined and so on).

The good news is that I think I know why: in the index.js file, we are using ReactNotification from the react-notifications-component, which weirdly does not exists (maybe it existed in previous versions). Instead, we should use named ReactNotifications.

Also, it seems like running npm install still changes package-lock a bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants