Fleshed out PostgresqlMessage, introduced PostgresqlServerFailure. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following an initial discussion https://github.com/penland365/roc/issues/21 on preferred Error Handling, the early implementation of PostgresqlError was replaced by PostgresqlMessage. Following the example set in Postgresql source code, all PostgresqlMessage were furthur classified into one of Success / Warning / Error / Unknown. A new failure type was introduced, PostgresqlServerFailure, to contain any ErrorMessage sent by a Postgresql Server. This implementation allows us to much more easily handle NoticeResponses, and allows us to have a more nuanced process ( yet to be implemented ) around connection handling.
Current coverage is
|
penland365
added a commit
that referenced
this pull request
Mar 22, 2016
Fleshed out PostgresqlMessage, introduced PostgresqlServerFailure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following an initial discussion #21 on preferred Error Handling, the early implementation of PostgresqlError was replaced by PostgresqlMessage. Following the example set in Postgresql source code, all PostgresqlMessage were furthur classified into one of Success / Warning / Error / Unknown. A new failure type was introduced, PostgresqlServerFailure, to contain any ErrorMessage sent
by a Postgresql Server.
This implementation allows us to much more easily handle NoticeResponses, and allows us to have a more nuanced process ( yet to be implemented ) around connection handling.