feat: replace Brand with Vendor
#38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
suggested changes
Jul 6, 2021
src/opencl/error.rs
Outdated
| #[error("Cannot get bus ID for device with vendor {0}")] | ||
| DeviceBusId(String), | ||
| #[error("Vendor {0} is not supported.")] | ||
| Vendor(String), |
There was a problem hiding this comment.
Maybe UnsupportedVendor would be a better name?
| } | ||
| false | ||
| }) | ||
| .map(|d| -> GPUResult<_> { |
There was a problem hiding this comment.
could use filter_map instead
There was a problem hiding this comment.
I've opened #42 for that.
There was a problem hiding this comment.
filter_map is implemented in https://github.com/filecoin-project/rust-gpu-tools/pull/39/files#diff-799aad7ae6bfd4ae76ce98c354a508494667af58cb53f46cd870be729603c9e6R84 as i needed it for other reasons anyway (it's not as pretty as expected, though).
src/opencl/utils.rs
Outdated
| all_devices.append(&mut devices); | ||
| } | ||
| Err(err) => { | ||
| let platform_name = platform.name().expect("Unable to get platform name"); |
There was a problem hiding this comment.
this shouldn't panic
| "AMD Accelerated Parallel Processing" => Some(Self::Amd), | ||
| "Apple" => Some(Self::Apple), | ||
| _ => None, | ||
| impl TryFrom<&str> for Vendor { |
There was a problem hiding this comment.
missing tests for this
The `Brand` was related to the platform. On Macs with an AMD graphics card, it would return `Apple`. This is not really helpful, therefore change it to `Vendor`, which will always contain the Vendor of the graphics card. BREAKING CHANGE: `Brand` is removed, use `Vendor` instead.
vmx
commented
Jul 6, 2021
| } | ||
| false | ||
| }) | ||
| .map(|d| -> GPUResult<_> { |
There was a problem hiding this comment.
I've opened #42 for that.
dignifiedquire
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Brandwas related to the platform. On Macs with an AMD graphicscard, it would return
Apple. This is not really helpful, thereforechange it to
Vendor, which will always contain the Vendor of thegraphics card.
BREAKING CHANGE:
Brandis removed, useVendorinstead.