Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit device filtering #42

Open
vmx opened this issue Jul 6, 2021 · 2 comments
Open

Revisit device filtering #42

vmx opened this issue Jul 6, 2021 · 2 comments

Comments

@vmx
Copy link
Collaborator

vmx commented Jul 6, 2021

The OpenCL code to get a device could need a refactor, it can likely be simplified.

@vmx
Copy link
Collaborator Author

vmx commented Sep 21, 2021

Related to this issue. We are currently filtering out all devices which are not AMD or Nvidia. This makes the library less general purpose. The reason to do this is, that you want to have a powerful GPU selected by default if one is available and not an integrated card.

I propose that we change the code, so that AMD and Nvidia cards are preferred, but if none are found, any other device that supports OpenCL will be used. This way rust-gpu-tools can also be used in libraries that only need it for testing and don't really need a powerful GPU.

@vmx
Copy link
Collaborator Author

vmx commented Oct 13, 2021

Another idea would be to expose filter capability. This means that rust-gpu-tools would be able to return all available graphic cards (perhaps with a custom sorter order, I propose Nvidia, AMD, Intel, others). One could then request only a subset of those, filtered by vendor. This way one of the upstream dependents, rust-fil-proofs, could request what is best for that library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant