Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear out old instances from partial message management #851

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

masih
Copy link
Member

@masih masih commented Jan 27, 2025

Once a decision about an instance is received, remove all states related to the older instances from partial message manager and chain exchange.

Part of #792

Once a decision about an instance is received, remove all states related
to the older instances from partial message manager and chain exchange.

Part of #792
@masih masih requested a review from Kubuxu January 27, 2025 13:35
@masih masih self-assigned this Jan 27, 2025
@masih masih added this to the M2: Mainnet Passive Testing milestone Jan 27, 2025
@masih masih force-pushed the masih/partial-msg-rm-instance branch from 9a3153d to e48860b Compare January 27, 2025 14:38
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 47.05882% with 18 lines in your changes missing coverage. Please review.

Project coverage is 67.29%. Comparing base (2d636c9) to head (e48860b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
partial_msg.go 21.73% 14 Missing and 4 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #851      +/-   ##
==========================================
- Coverage   67.36%   67.29%   -0.07%     
==========================================
  Files          83       83              
  Lines        9024     9055      +31     
==========================================
+ Hits         6079     6094      +15     
- Misses       2410     2423      +13     
- Partials      535      538       +3     
Files with missing lines Coverage Δ
chainexchange/pubsub.go 71.24% <100.00%> (+3.40%) ⬆️
host.go 66.05% <100.00%> (+0.28%) ⬆️
partial_msg.go 58.65% <21.73%> (-4.42%) ⬇️

... and 5 files with indirect coverage changes

@masih masih added this pull request to the merge queue Jan 27, 2025
Merged via the queue into main with commit bae93e2 Jan 27, 2025
12 of 14 checks passed
@masih masih deleted the masih/partial-msg-rm-instance branch January 27, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants