Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently use Merkle Tree root as ECChain key #834

Merged
merged 4 commits into from
Jan 24, 2025

Bump timeout for `TestF3LateBootstrap` to unblock progress

dda094f
Select commit
Loading
Failed to load commit list.
Merged

Consistently use Merkle Tree root as ECChain key #834

Bump timeout for `TestF3LateBootstrap` to unblock progress
dda094f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 24, 2025 in 0s

67.26% (-0.06%) compared to 5c916d1

View this Pull Request on Codecov

67.26% (-0.06%) compared to 5c916d1

Details

Codecov Report

Attention: Patch coverage is 89.28571% with 27 lines in your changes missing coverage. Please review.

Project coverage is 67.26%. Comparing base (5c916d1) to head (dda094f).

Files with missing lines Patch % Lines
partial_validator.go 27.27% 8 Missing ⚠️
chainexchange/pubsub.go 78.26% 4 Missing and 1 partial ⚠️
cbor_gen.go 20.00% 1 Missing and 3 partials ⚠️
gpbft/chain.go 96.11% 2 Missing and 2 partials ⚠️
partial_msg.go 70.00% 3 Missing ⚠️
observer/model.go 0.00% 2 Missing ⚠️
gpbft/gpbft.go 97.61% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #834      +/-   ##
==========================================
- Coverage   67.31%   67.26%   -0.06%     
==========================================
  Files          84       83       -1     
  Lines        9001     9017      +16     
==========================================
+ Hits         6059     6065       +6     
- Misses       2407     2413       +6     
- Partials      535      539       +4     
Files with missing lines Coverage Δ
certchain/certchain.go 62.81% <100.00%> (ø)
certs/certs.go 92.68% <100.00%> (ø)
consensus_inputs.go 61.87% <100.00%> (-1.26%) ⬇️
emulator/driver_assertions.go 100.00% <100.00%> (ø)
emulator/host.go 77.77% <100.00%> (ø)
emulator/instance.go 89.65% <100.00%> (-4.32%) ⬇️
gpbft/validator.go 91.50% <100.00%> (ø)
host.go 65.09% <100.00%> (+1.18%) ⬆️
merkle/merkle.go 92.30% <ø> (ø)
gpbft/gpbft.go 89.97% <97.61%> (+0.27%) ⬆️
... and 6 more

... and 4 files with indirect coverage changes